refactor(rpc): clean up api.rs with section separators and comments#1713
Merged
Mirko-von-Leipzig merged 4 commits into0xMiden:nextfrom Feb 27, 2026
Merged
Conversation
eren-karakus0
added a commit
to eren-karakus0/node
that referenced
this pull request
Feb 26, 2026
Organize `crates/rpc/src/server/api.rs` for better readability: - Add section separators (API IMPLEMENTATION, HELPERS) following project conventions - Add subsection comments grouping methods by category (nullifier, block, note, account, transaction submission, status & utility) - Reorder methods within the impl block to match logical grouping - Extract duplicated decorator stripping logic into `strip_output_note_decorators` helper function - Add doc comments to non-trivial methods (submit_proven_transaction, submit_proven_batch, get_account) No logic changes - purely organizational. Closes 0xMiden#1458
eren-karakus0
force-pushed
the
fix/issue-1458-cleanup-rpc-api
branch
from
be752bb to
d0caebd
Compare
Mirko-von-Leipzig
added
the
no changelog
Mirko-von-Leipzig
requested changes
Feb 27, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Thank you, just the changelog entry removal.
This looks quite a lot better!
Mirko-von-Leipzig
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Organizes
crates/rpc/src/server/api.rsfor better readability as requested in #1457 review comment:API IMPLEMENTATION,HELPERS) following project conventionsimpl Apiblock to match logical groupingstrip_output_note_decoratorshelper functionsubmit_proven_transaction,submit_proven_batch,get_account)No logic changes — purely organizational.
Closes #1458