fix(store): network notes must be public#1738
Open
Mirko-von-Leipzig wants to merge 3 commits intonextfrom
Open
fix(store): network notes must be public#1738Mirko-von-Leipzig wants to merge 3 commits intonextfrom
Mirko-von-Leipzig wants to merge 3 commits intonextfrom
Conversation
Mirko-von-Leipzig
force-pushed
the
mirko/fix-network-notes-next
branch
from
b2c665b to
7f40b6a
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/fix-network-notes-next
branch
from
7f40b6a to
313defa
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/fix-network-notes-next
branch
from
313defa to
22869b2
Compare
SantiagoPittella
approved these changes
Mar 3, 2026
| account_id: conversions::network_account_id_to_bytes(note.account_id()), | ||
| note_data: conversions::single_target_note_to_bytes(note), | ||
| nullifier: conversions::nullifier_to_bytes(¬e.as_note().nullifier()), | ||
| account_id: conversions::network_account_id_to_bytes( |
Collaborator
There was a problem hiding this comment.
nit: there's a bit of an inconsistency on how we are casting to bytes. In https://github.com/0xMiden/node/pull/1738/changes#diff-18f92718b4914ffa99386fe38041dec4064cde98763edefa1f8750462449af70R142 we are using:
nullifier: note.as_note().nullifier().to_bytes(),
account_id: note.target_account_id().to_bytes(),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counterpart of #1736 for the
nextbranch.This PR updates
miden-protocolto include 0xMiden/protocol#2365 which added network note support. This PR then replaces our adhoc (and faulty) implementation with the one from protocol.This does leave our types and conversions in a bit of a wonky state -- things could be cleaned up further, but since we're already actively refactoring the ntx-builder I've elected to not do this.
Fixes #1726