Closed
Conversation
Pin protocol dependencies to published crate versions and update all workspace crate versions to =0.14.0-alpha.1. https://claude.ai/code/session_017j1F8cwRXFnWyjzzwN9d4k
Use github.event.release.target_commitish to dynamically determine which branch to checkout and verify against, instead of hardcoding main. This enables releasing alpha versions from the next branch. https://claude.ai/code/session_017j1F8cwRXFnWyjzzwN9d4k
mmagician
force-pushed
the
claude/bump-protocol-alpha-TUbxC
branch
from
885ae64 to
5c6f635
Compare
mmagician
added
the
no changelog
The miden-protocol 0.14.0-alpha.1 crate introduced `StorageMapKey` as a newtype wrapper around `Word` for storage map keys, and removed `StorageMap::hash_key()`. This commit updates all call sites: - Replace `StorageMap::hash_key(key)` with `StorageMapKey::new(key).hash().as_word()` - Change `get_storage_map_witness` signatures to accept `StorageMapKey` - Convert `StorageMap::entries()` results from `(StorageMapKey, Word)` to `(Word, Word)` where needed - Use `StorageMapKey` in `StorageMap::with_entries()` and `StorageMapDelta::insert()` calls - Update all affected tests https://claude.ai/code/session_017j1F8cwRXFnWyjzzwN9d4k fix: adapt to protocol StorageMapKey type changes Use StorageMapKey/StorageMapKeyHash types from miden-protocol 0.14.0-alpha.1 instead of raw Word throughout the codebase. Key changes: - StorageMap::hash_key() removed → use StorageMapKey::new(w).hash().as_word() - StorageMap::entries() returns (&StorageMapKey, &Word) instead of (&Word, &Word) - DataStore::get_storage_map_witness takes StorageMapKey instead of Word - StorageMapDelta::insert() takes StorageMapKey instead of Word - StorageMap::with_entries() takes (StorageMapKey, Word) pairs - Domain types StorageMapEntries and SlotData use StorageMapKey - InnerForest::storage_entries uses BTreeMap<StorageMapKey, Word> - Convert to Word only at DB serialization boundary https://claude.ai/code/session_017j1F8cwRXFnWyjzzwN9d4k
mmagician
force-pushed
the
claude/bump-protocol-alpha-TUbxC
branch
from
fb69866 to
cb39982
Compare
Contributor
Author
|
superseded by #1743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.14.0-alpha.1main(in particular, after merging this tonext, we'll branch off to a newrelease/v0.14.0-alphafrom which the alpha release will be triggered