Conversation
bobbinth
added
no changelog
igamigo
force-pushed
the
igamigo-map-proof
branch
3 times, most recently
from
8a2ed6a to
c2ec0c2
Compare
igamigo
requested review from
Mirko-von-Leipzig and
bobbinth
and removed request for
bobbinth
igamigo
force-pushed
the
igamigo-map-proof
branch
from
363acf2 to
acee4bc
Compare
tomyrd
approved these changes
Jan 7, 2025
Contributor
tomyrd
left a comment
tomyrd
left a comment
There was a problem hiding this comment.
Looks good! Left one small question, I don't see it as a blocker though, just curious.
bobbinth
approved these changes
Jan 13, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a few small comments inline. Once these are addressed we can merge.
As I mentioned in one of the comments, this approach is fine for now, but we should refactor both how we store public account data and how we provide the data to the client.
| .find(|info| info.summary.account_id == request.account_id) | ||
| .expect("retrieved accounts were validated against request"); | ||
|
|
||
| if let Some(details) = &account_info.details { |
Contributor
There was a problem hiding this comment.
Not for this PR: this approach works fine for now, but it won't work with large accounts (i.e., we are loading the full account state into memory and then selecting key-value pairs from it).
…instead of retreived accounts; README suggestions
igamigo
force-pushed
the
igamigo-map-proof
branch
from
d30c562 to
1b7e181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #596