Conversation
Closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mmagician
requested review from
Dominik1999 and
partylikeits1983
and removed request for
partylikeits1983
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Dominik1999
reviewed
Aug 7, 2025
Collaborator
Dominik1999
left a comment
Dominik1999
left a comment
There was a problem hiding this comment.
Thank you very much. I love that approach, this will help us to maintain our tutorials way easier.
Some comments:
- You changed the code snippets and added some code in a uncommented state, can you explain the reasoning behind it?
- Can we do the same for the WebClient tutorials? I think the WebClient will be even more important than the Rust client
partylikeits1983
approved these changes
Aug 7, 2025
Collaborator
partylikeits1983
left a comment
partylikeits1983
left a comment
There was a problem hiding this comment.
This is amazing, thank you! This is going to save a lot of time.
Dominik1999
approved these changes
Aug 9, 2025
Collaborator
Dominik1999
left a comment
Dominik1999
left a comment
There was a problem hiding this comment.
Thanks, now I understand the usage of #
This was referenced Aug 11, 2025
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All rust-client tutorials are runnable with
cargo test --doc --release(from thedocsdirectory), except for the oracle one (pending the contract update).