Support new `PrimaryConstructorInformationBlob` Roslyn CDI #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wtfsck merged 1 commit into 0xd4d:master from ElektroKill:new-roslyn-cdi

Jul 9, 2023

Contributor

ElektroKill commented Jun 10, 2023

No description provided.


          Support new PrimaryConstructorInformationBlob Roslyn CDI

831661a

Contributor

wtfsck commented Jul 8, 2023

Does this blob contain any metadata tokens?

Contributor Author

ElektroKill commented Jul 8, 2023

Does this blob contain any metadata tokens?

Glancing at Roslyn source code, it seams to me that this blob is, at least for now, always empty.
Code which adds the CDI in Roslyn:
https://github.com/dotnet/roslyn/blob/5100eeedfe43c45b53fc298d6341d4d52e0d735a/src/Compilers/Core/Portable/PEWriter/MetadataWriter.PortablePdb.cs#L144-L150
Code which reads it (according to GitHub search there is only one place where it is read and that is the Debugger EE)
https://github.com/dotnet/roslyn/blob/5100eeedfe43c45b53fc298d6341d4d52e0d735a/src/ExpressionEvaluator/Core/Source/ExpressionCompiler/PDB/MethodDebugInfo.Portable.cs#L401

wtfsck approved these changes

View reviewed changes

wtfsck merged commit c0daec9 into 0xd4d:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet