Skip to content

fix: ensure child processes die when parent exits (Windows)#5

Merged
0xeb merged 1 commit intomainfrom
fix/job-object-child-cleanup
Jan 30, 2026
Merged

fix: ensure child processes die when parent exits (Windows)#5
0xeb merged 1 commit intomainfrom
fix/job-object-child-cleanup

Conversation

@0xeb
Copy link
Owner

@0xeb 0xeb commented Jan 30, 2026

Summary

  • Add Windows Job Object with JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE flag to automatically terminate spawned child processes when the parent process exits
  • Prevents orphaned server processes when client crashes or is forcefully terminated

Test plan

  • All unit tests pass (114/114)
  • All E2E tests pass (41/43, 2 skipped unrelated)
  • Verified process spawning still works correctly

Add Job Object with JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE flag to automatically
terminate spawned child processes when the client process terminates,
even if it crashes or is killed. This prevents orphaned server processes.
@0xeb 0xeb merged commit 38fa0af into main Jan 30, 2026
3 checks passed
@0xeb 0xeb deleted the fix/job-object-child-cleanup branch January 30, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant