Lazy-import heavy modules for faster startup#183
Open
oxysoft wants to merge 1 commit into1038lab:mainfrom
Open
Lazy-import heavy modules for faster startup#183oxysoft wants to merge 1 commit into1038lab:mainfrom
oxysoft wants to merge 1 commit into1038lab:mainfrom
Conversation
Move groundingdino, transformers, matplotlib, cv2, diffusers, onnxruntime, and scipy imports from module top-level into function bodies. This defers loading until actual use, reducing import time from ~15.6s to <0.1s during ComfyUI startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
groundingdino,transformers,matplotlib,cv2,diffusers,onnxruntime, andscipyimports from module top-level into function bodiesDetails
ComfyUI imports all custom nodes at startup to discover
NODE_CLASS_MAPPINGS. The current top-level imports pull in the entire groundingdino → timm → wandb dependency chain (~12s alone) plus transformers (~3.7s) even before any node is used.By moving these imports into the methods that actually need them, the node classes register instantly and libraries only load when a user first queues a workflow that uses them.
11 files in
py/modified. No functional changes — just import relocation.Test plan
python -X importtimeor similar