Propagate microarchitecture flags to C++ build.#53
Merged
adam-azarchs merged 1 commit intomasterfrom Dec 10, 2022
Merged
Conversation
Also, update CI rust version to 1.65, and fix clippy lints.
adam-azarchs
force-pushed
the
azarchs/flags
branch
from
c5c47f1 to
bdd818b
Compare
bgianfo
approved these changes
Dec 10, 2022
bgianfo
reviewed
Dec 10, 2022
| .compile("orbit"); | ||
| .flag("-fvisibility=hidden"); | ||
|
|
||
| if cfg!(target_feature = "sse3") { |
Member
There was a problem hiding this comment.
Thinking out loud: Are we going to be applying this pattern to other repositories? Would it make sense to put this in a crate for sharing across repos?
Member
Author
There was a problem hiding this comment.
Unfortunately macros don't share easily. Really this should be a thing that cc just knows how to do itself. (I guess I should probably check whether it does, now that I think about it)
Member
Author
There was a problem hiding this comment.
Actually, cc does honor CFLAGS, so this won't actually do anything in our bazel build. Still useful when doing a native cargo build, for micro-benchmarks.
evolvedmicrobe
approved these changes
Dec 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, update CI rust version to 1.65, and fix clippy lints.