Skip to content

feat/886: Add Default Template global settings for Recommended Content Block#917

Merged
dkotter merged 10 commits into
feature/query-variation-blockfrom
feat/default-templates
Jun 10, 2025
Merged

feat/886: Add Default Template global settings for Recommended Content Block#917
dkotter merged 10 commits into
feature/query-variation-blockfrom
feat/default-templates

Conversation

@Sidsector9
Copy link
Copy Markdown
Member

Description of the Change

Closes #886

How to test the Change

  1. Visit the page /wp-admin/tools.php?page=classifai#/personalizer/feature_recommended_content.
  2. Select a Default Template and save the settings.
  3. Follow the instructions from PR Recommended Content Block powered by AI embeddings #881 to insert the Recommended Content Block.
  4. Verify if the template set in the block is the same as the Default Template set in the settings.

Screencast:

Screen-2025-05-23-90209.PM.mp4

Changelog Entry

Added - Default Template global settings for Recommended Content Block

Credits

Props @dkotter @Sidsector9

Checklist:

@Sidsector9 Sidsector9 requested review from a team, dkotter and jeffpaul as code owners May 23, 2025 15:38
@Sidsector9 Sidsector9 self-assigned this May 23, 2025
@Sidsector9 Sidsector9 force-pushed the feat/default-templates branch from 769bd17 to 82c7ab9 Compare May 23, 2025 17:27
@jeffpaul jeffpaul removed their request for review June 2, 2025 14:47
Copy link
Copy Markdown
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this (and apologies on late review here). Left one comment but I think we need to be a bit more strict on the templates here. What I'm seeing now is pagination gets added, which isn't desired for a recommended content section. Is there a way to remove that piece? It also doesn't render in the way I'd expect, it renders stacked now instead of in a column layout.

Comment on lines +6 to +7
import { registerPlugin } from '@wordpress/plugins';
import { Fill } from '@wordpress/components';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems neither of these is currently used?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@jeffpaul jeffpaul added this to the 3.4.0 milestone Jun 6, 2025
@jeffpaul jeffpaul moved this to In Progress in Open Source Practice Jun 6, 2025
@Sidsector9 Sidsector9 requested a review from dkotter June 9, 2025 04:14
Copy link
Copy Markdown
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the work on this. I think we may want to register our own templates in the future, rather than relying on whatever default templates are registered, to provide a few more options but this looks good as a starting point

@github-project-automation github-project-automation Bot moved this from In Progress to QA Testing in Open Source Practice Jun 10, 2025
@dkotter dkotter merged commit da7984b into feature/query-variation-block Jun 10, 2025
1 check passed
@dkotter dkotter deleted the feat/default-templates branch June 10, 2025 19:40
@github-project-automation github-project-automation Bot moved this from QA Testing to Done in Open Source Practice Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants