Skip to content

Update linting actions to support GH Actions summary #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinhtungdu merged 17 commits into from
Jun 29, 2022
Merged

Update linting actions to support GH Actions summary #128

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8633b20
test branch
dinhtungdu May 15, 2022
fb2d65b
test branch
dinhtungdu May 15, 2022
5ac61dc
add summary step
dinhtungdu May 15, 2022
c095032
always run step
dinhtungdu May 15, 2022
5bb16b4
use extra_args
dinhtungdu May 15, 2022
7857301
test
dinhtungdu May 15, 2022
fa90015
try: eslint summary
dinhtungdu May 16, 2022
e5c9b0d
fix report command
dinhtungdu May 16, 2022
e939b1d
try: use default node version
dinhtungdu May 16, 2022
3aab9d5
use if: always to avoid marking failed check as passing
dinhtungdu May 16, 2022
8824f12
remove left over continue on error flag
dinhtungdu May 16, 2022
29faf83
use continue on error for linting step only
dinhtungdu May 16, 2022
5e74199
only run report action on failure
dinhtungdu May 16, 2022
3849fb5
remove test liniting error
dinhtungdu May 17, 2022
4edda3c
fix phpcs linting errors
dinhtungdu May 17, 2022
49bce26
change the wpcs action branch back to stable
dinhtungdu Jun 15, 2022
21fbb32
Merge branch 'develop' into test/wpcs-gh-actions-summary
jeffpaul Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,22 @@ jobs:
name: eslint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: install node v12
uses: actions/setup-node@v1
with:
node-version: 12
- name: npm install
run: npm install
- name: eslint
uses: icrawl/action-eslint@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@v2
- name: npm install
run: npm install
- name: Generate linting report
run: npm run lint:js -- --output-file eslint-report.json --format json
continue-on-error: true
- name: Annotate code linting results
uses: ataylorme/eslint-annotate-action@1.2.0
with:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
report-json: 'eslint-report.json'
- name: Update summary
run: |
npm_config_yes=true npx github:10up/eslint-json-to-md --path ./eslint-report.json --output ./eslint-report.md
cat eslint-report.md >> $GITHUB_STEP_SUMMARY
if: ${{ failure() }}
phpcs:
name: WPCS
runs-on: ubuntu-latest
Expand All @@ -34,3 +39,9 @@ jobs:
uses: 10up/wpcs-action@stable
with:
use_local_config: true
extra_args: '--report-json=./phpcs-report.json'
- name: Update summary
run: |
npx github:10up/phpcs-json-to-md --path ./phpcs-report.json --output ./phpcs-report.md
cat phpcs-report.md >> $GITHUB_STEP_SUMMARY
if: ${{ failure() }}