Add cross-env package and update package.json Node env scripts

[JustinyAhin]

Description of the Change

NODE_ENV is not a recognized command for Windows terminal and for older versions of PowerShell. That means that when running npm run dev, npm run build, etc on Windows machine, the script of package.json is not going to work.

So, I've added the package cross-env and change the NODE_ENV lines in the script to cross-env NODE_ENV so that it can be executed on any type of environnement.

Alternate Designs

Benefits

Execute package.json no matter the environment used.

Possible Drawbacks

The change doesn't seems to have drawbacks

Verification Process

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

#148

[timwright12]

@magnificode can you check this one out and confirm since you have a windows machine?

[samikeijonen]

We have noticed need for cross-env in our personal project, +1 from me.

[samikeijonen]

@magnificode Do you happen to have time to check this?

[magnificode]

So so so sorry for the delay. This looks great, CSS and JS compile perfectly on Windows. 👍

[magnificode]

@samikeijonen @timwright12 - for the record I'm compiling via WSL. The Linux subsystem on Windows doesn't require me to utilize PowerShell to compile which is what this PR solves.

In any case, if this solves the issue @JustinyAhin brought up, I'm all for it, as it will ensure that this theme is accessible to folks developing on machines with older versions of PowerShell!

[timwright12]

We'll need to get this into the plugin repo before a merge

[samikeijonen]

@timwright12 Added in plugin repo.

[samikeijonen]

Any progress on this?

[ivankruchkoff]

Any updates here?

[jeffpaul]

@timwright12 we good to resolve the merge conflict here and then merge this PR and the related one over in the plugin repo?

[samikeijonen]

@joesnellpdx Can we get this in?

[smy315]

+1 to get this merged. I'm not a Windows user myself but we had to add this exact update yesterday on a project for other Window users on the project.

@samikeijonen also noticed that there is a merge conflict now with this PR. Might want to update it so this can get merged in.

[joesnellpdx]

@samikeijonen @smy315 this is merged