FacePrioritySorter Optimizations #910
Open
+859
−711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
5 times, most recently
from
f618fb6 to
e2e93af
Compare
RuffledPlume
changed the title
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
2 times, most recently
from
52f5ea6 to
8ad7cf4
Compare
Contributor
Author
|
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
3 times, most recently
from
6d9ef02 to
684533d
Compare
Contributor
Author
|
Updated Timings in the same view as the above: |
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
6 times, most recently
from
cc62cec to
c0220f9
Compare
Contributor
Author
|
Same view, even faster now: 
|
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
3 times, most recently
from
2ad984a to
08d7189
Compare
Contributor
Author
|
Final test in the same view: |
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
2 times, most recently
from
49f7767 to
7cea999
Compare
Contributor
Author
|
Ok Ok, this time for real final perf improvement: |
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
3 times, most recently
from
b48fd2b to
74bb319
Compare
Contributor
Author
|
Actual final improvements this time, between this & last perf report I've offloaded the copy to the mapped buffer onto a job per zone, with the job being waited on in drawPass |
Contributor
Author
|
Priff Perf testing curtsey of Jin PR: |
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
2 times, most recently
from
b3e36c3 to
0bf3aa3
Compare
Reworked FacePriortySorter to build an indicie array which is passed into SceneUploader Alpha Models now have the sorted faces uploaded first, then unsorted last to allow for drawElements & drawArrays to work, meaning shadow rendering can use the sorted model data Tweaks
Use Stamp Check as a slow path vs fast path
Sort Zones close accurately, then sort zones past the mid range with significantly less accuracy. Then dont sort at all for the furthest zones
multizoneLocs was failing due to zones being culled, causing flickering models when nearby zones we're culled. Instead of performing multizoneLocs in drawAlpha we should do it in preSceneDraw regardless of visibility, this allows us to do more accurate culling again saving allot of perf multizoneLocs should find the closest visible zone & padd scene frustum check Sync
…h & Dist are the same
Sync Fix Plugin Reload
RuffledPlume
force-pushed
the
SortedModelUploadRework
branch
2 times, most recently
from
c6435b0 to
ae1ab84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked FacePriortySorter to build an indicie array which is passed into SceneUploader
Alpha Models now have the sorted faces uploaded first, then unsorted last to allow for drawElements & drawArrays to work, meaning shadow rendering can use the sorted model data