Avoid use of reserved word interface
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In strict mode, `interface` is a reserved word. Or, at least _will_ be a reserved word in the future: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#future_reserved_words This change uses destructuring to avoid use of `interface` in the `filter` and `map` callbacks.
Contributor
Author
|
As it turns out, #96 is blocked by this since ECMAScript modules run in strict mode. |
Member
|
Related 11ty/eleventy#3836 (this work is already done but not yet pushed!) |
Member
|
Shipping with Dev Server v3.0.0-alpha.1 Thank you so much! |
Contributor
Author
|
Thanks for the merge! 🙌🏻 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an interesting-to-me issue while experimenting with Eleventy and Cloudflare Pages Functions (see this toot).
In strict mode,
interfaceis a reserved word. Or, at least will be a reserved word in the future. Something within Cloudflare's stack (esbuild, I suspect) is running in strict mode and threw this error:Hunh. Well, TIL as they say.
This change uses destructuring to avoid use of
interfacein thefilterandmapcallbacks. If destructuring isn't preferred, an alternative implementation could change the use ofinterfacetoifaceor similar.Thanks for considering this change!