Settings: Garden permissions #860
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,118 @@ | |||
| /* eslint-disable react/jsx-key */ | |||
There was a problem hiding this comment.
Maybe the problem with names don't show up could be related to it. Same if it's not, I'll recommend remove it and set proper keys attributes to react render properly
There was a problem hiding this comment.
I don't think we really need this line also.
tmoutinho
left a comment
tmoutinho
left a comment
There was a problem hiding this comment.
Good job :fire. just a small comment.
| import Permissions from './Permissions' | ||
|
|
||
|
|
||
| const LayoutWrapper = styled(Layout)` |
| @@ -0,0 +1,118 @@ | |||
| /* eslint-disable react/jsx-key */ | |||
There was a problem hiding this comment.
I don't think we really need this line also.
| getEvmCrispr() | ||
| }, [account, connectedGarden, ethers, isSafari]) | ||
|
|
||
| console.log('sectionIndex ', sectionIndex) |
There was a problem hiding this comment.
Maybe remove the console log here
| appAddress: string, | ||
| appName: string, | ||
| appIcon: string, | ||
| description: string | undefined, // TODO- check why this is happening proabably old ABI |
There was a problem hiding this comment.
You are still getting undefined here some times?
| } | ||
|
|
||
| const rolesWithEntitiesResolved: Array<RoleProps> = appsWithRolesResolved ? appsWithRolesResolved.map((app: any) => { | ||
| return app.roles.map((role: any) => { |
There was a problem hiding this comment.
It's possible we get the correct type here in instead any, it could help track changes in the code below
Still didn't added the filters since is going to take me some time given the way the connect returns the data for the roles but i can add later in another pr since i want to move to work on the conviction voting v2.
There is one case where the permission has no name for some reason, needs further investigation.