Skip to content

fix: enhance app icon retrieval logic in home view #11745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssongliu merged 1 commit into from
Jan 30, 2026
Merged

fix: enhance app icon retrieval logic in home view #11745

ssongliu merged 1 commit into from
Jan 30, 2026
+10 −2

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Jan 29, 2026 •
edited
Loading

  • Updated app icon handling to use a dedicated function for improved clarity and maintainability.
  • Introduced a new method, getAppIconSrc, to manage icon source retrieval based on app properties.
  • Ensured proper handling of base64 and URL-based icons for better performance and consistency.

What this PR does / why we need it?

修复新版图标存储逻辑情况下，首页无法加载 icon 的问题

Summary of your change

前端自动判断b64 还是 新格式。兼容原版和新存储方案
image

@HynoR
feat: enhance app icon retrieval logic in home view
7741cf9 
- Updated app icon handling to use a dedicated function for improved clarity and maintainability.
- Introduced a new method, getAppIconSrc, to manage icon source retrieval based on app properties.
- Ensured proper handling of base64 and URL-based icons for better performance and consistency.
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 29, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HynoR HynoR changed the title feat: enhance app icon retrieval logic in home view fix: enhance app icon retrieval logic in home view Jan 30, 2026
@ssongliu ssongliu merged commit 564333e into 1Panel-dev:dev-v2 Jan 30, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HynoR @ssongliu