Fix Windows clipboard behavior and improve documentation#89
Merged
Conversation
complexspaces
force-pushed
the
windows-clipboard-redo
branch
2 times, most recently
from
c008699 to
9340053
Compare
emilk
reviewed
Oct 27, 2022
This adds unit tests to back up the crate's documentation to prevent silent regressions in the future.
complexspaces
force-pushed
the
windows-clipboard-redo
branch
from
9340053 to
0fd5730
Compare
ArturKovacs
approved these changes
Oct 31, 2022
Collaborator
ArturKovacs
left a comment
ArturKovacs
left a comment
There was a problem hiding this comment.
Thanks for this PR. I ran into this myself, I'm looking forward to seeing this merged.
Member
Author
|
@ArturKovacs This is now released as |
This was referenced Nov 5, 2022
Collaborator
|
Awesome! ♥ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the inconsistent behavior introduced by #60 on Windows that made
arboard's semantics entirely different on Windows vs the other platforms, preventing reasonable cross-platform usage.In addition, it improves the documentation of
Clipboardto note that your app's usage of arboard may differ depending on what combination of platforms are being targeted. For example, if you're only targeting macOS and Windows, nothing beyond opening and using the clipboard in a one-off fashion is needed. However if Linux is used1, then one copy of the clipboard should be kept around at all times.Closes #88
Footnotes
The
SetLinuxExtbuilder can help with some of these cases, but is not a universal solution for all apps. ↩