Add support for DateTime field for Go, JS, Python #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al implementation for the other languages
MOmarMiraj
commented
Mar 12, 2025
hculea
reviewed
Mar 13, 2025
hculea
reviewed
Mar 13, 2025
hculea
reviewed
Mar 13, 2025
hculea
reviewed
Mar 13, 2025
hculea
reviewed
Mar 13, 2025
hculea
reviewed
Mar 13, 2025
hculea
reviewed
Mar 13, 2025
hculea
reviewed
Mar 14, 2025
core/data/tests/test_custom_serialize_deserialize_functions/output.go
Outdated
Show resolved
Hide resolved
hculea
reviewed
Mar 14, 2025
hculea
reviewed
Mar 14, 2025
core/data/tests/test_custom_serialize_deserialize_functions/output.ts
Outdated
Show resolved
Hide resolved
hculea
reviewed
Mar 14, 2025
core/data/tests/test_custom_serialize_deserialize_functions/output.ts
Outdated
Show resolved
Hide resolved
… imports to reduce diff
hculea
reviewed
Mar 14, 2025
hculea
reviewed
Mar 14, 2025
hculea
reviewed
Mar 14, 2025
core/data/tests/test_custom_serialize_deserialize_functions/output.ts
Outdated
Show resolved
Hide resolved
hculea
reviewed
Mar 14, 2025
core/data/tests/test_custom_serialize_deserialize_functions/input.rs
Outdated
Show resolved
Hide resolved
hculea
reviewed
Mar 14, 2025
core/data/tests/test_custom_serialize_deserialize_functions/output.py
Outdated
Show resolved
Hide resolved
hculea
reviewed
Mar 14, 2025
hculea
approved these changes
Mar 14, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add
DateTimesupport from the ruststd::time::OffSetTimelibrary for Go, JS, and Python. The other languages are not supported yet as lack of expertise in those areas.I am keeping the same implementation for Scala, Kotlin, and Swift to ensure backwards compatibility. (i.e. if you used to type map DateTime -> string).