wrong name ja2 executable in SCI

[tais]

it seems the executable in the SCI's has the wrong name, this should be named ja2.exe to make sure it overwrites the original JA2 executable, people will run into issues staring the old exe and get confused if this file is not overwritten.

[kitty624]

i think a copy of exe named "ja2" would be better than only ja2. right now, the exe in gitHub-build contains date and hash of latest source commit. example: "ja2_113_20221122_7a0a567.exe" This way, users and developers know which version is refered to at reports. if that would be only "ja2", we'd have to find another way to provide this information.
At the moment, when I grab the files from gitHub-build for the SCI uploaded by me, I do the "add a copy of exe named ja2"-thing already.
So, if technically possible, I'll opt for adding a copy of exe, named "ja2", to gitHub-build.

[kitty624]

P.S. Naming it "ja2_113_20221122_7a0a567.exe" stems from discord exchanges, maybe a gitHub-channel there would be an idea?

[rftrdev]

I'll update the build action, and add a readme with version info instead of putting that into the filename

[rftrdev]

@kitty624 - what would be the ideal change to the output to make things easy for you? Keep the existing .exe outputs and add a plain "ja2.exe"? I can also generate a text file with both source and gamedir version info.

[kitty624]

Most user-friendly would probably be to name the exe-files "ja2", "ja2 UB" and "ja2 MapEditor" plus a readme with both hashs and date of latest source commit.
When i repack them with 7zip, i add date and hashs to zip, also seen the polish forum adding the hashs. If that's possible for artifact zip it could be convinient for those that grab it dirctly or for future releases via GitHub.
I think Asdow is also member at polish forum maybe he can convey the thing about Version-in-readme, since this forum is more active as Bearspit and to some degree being on same page with naming would be less a pain for players.

[rftrdev]

How's this: rename the output exes to "ja2.exe", "ja2ub.exe", and "ja2mapeditor.exe", and add a version info text file that looks something like this:

If you encounter problems during gameplay, please give the following version information:
Source SHA: <latest source commit hash; eg 48f3476>
Source Date: <latest source commit date; eg 20221203>
Gamedir SHA: <latest gamedir commit hash; eg 46486599>
Gamedir Date: <latest gamedir commit date; eg 20221110>

What else would be good/useful to include in the text file? And any preference on a file name?

[tais]

I'd call it something like ja2-release.txt

[rftrdev]

Committed with #40