Add on option to start at maximum aiming level#112
Merged
Conversation
When hovering mouse on an enemy, aiming level is started at maximum instead of no aiming when this option is toggled.
majcosta
reviewed
Jan 22, 2023
Comment on lines
+461
to
+467
| const bool isCursorOnTarget = ( | ||
| guiNewUICursor == ACTION_SHOOT_UICURSOR || guiNewUICursor == ACTION_TARGETBURST_UICURSOR || | ||
| guiNewUICursor == ACTION_FLASH_SHOOT_UICURSOR || guiNewUICursor == ACTION_FLASH_BURST_UICURSOR || | ||
| guiNewUICursor == ACTION_NOCHANCE_SHOOT_UICURSOR || guiNewUICursor == ACTION_NOCHANCE_BURST_UICURSOR | ||
| ); | ||
| // Start at maximum aiming levels if the option is toggled | ||
| if (gGameSettings.fOptions[TOPTION_ALT_START_AIM] && isCursorOnTarget) |
Contributor
There was a problem hiding this comment.
Either squash this commit onto the previous, or move the UI Cursors changes in the previous commit to this one.
This 'Commit A - Did something', 'Commit B - Fix something that was wrong in commit A' structure makes it harder to review this, not easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hovering mouse on an enemy, aiming level is started at maximum instead of no aiming when this option is toggled. Can be toggled on/off from options screen ingame at any point.
Closes #109