Skip to content

Remove gszCivGroupNames dependency from main executable#114

Merged
majcosta merged 3 commits into
1dot13:masterfrom
majcosta:pr_move_editor_thing_into_editor
Jan 26, 2023
Merged

Remove gszCivGroupNames dependency from main executable#114
majcosta merged 3 commits into
1dot13:masterfrom
majcosta:pr_move_editor_thing_into_editor

Conversation

@majcosta
Copy link
Copy Markdown
Contributor

gszCivGroupNames is used by the Map Editor, but not by the game. move it from Tactical to the Map Editor.

@kitty624
Copy link
Copy Markdown
Contributor

Not sure if i understand. I've no clue about the code side, but they are used in gamedir also

So, would that removal have any impact on the lua and xml where those names are used?

-It's used in lua scripts also, not only MapEditor
-and in the civgroupnames.xml of course
-and those are shown over head ingame

i think the lua part is rather important, they are used quite often

some lua Examples are:

in
Explosion.lua

SetCivGroupHostile( Group.KINGPIN_CIV_GROUP , Civ_status.CIV_GROUP_HOSTILE )

in
overhead.lua

Group =
{
NON_CIV_GROUP = 0,
REBEL_CIV_GROUP = 1,
KINGPIN_CIV_GROUP = 2,
SANMONA_ARMS_GROUP = 3,
ANGELS_GROUP = 4,
BEGGARS_CIV_GROUP = 5,
TOURISTS_CIV_GROUP = 6,
ALMA_MILITARY_CIV_GROUP = 7,
DOCTORS_CIV_GROUP = 8,
COUPLE1_CIV_GROUP = 9,
HICKS_CIV_GROUP = 10,
WARDEN_CIV_GROUP = 11,
JUNKYARD_CIV_GROUP = 12,
FACTORY_KIDS_GROUP = 13,
QUEENS_CIV_GROUP = 14,
}

@majcosta majcosta merged commit d007d3b into 1dot13:master Jan 26, 2023
@majcosta majcosta deleted the pr_move_editor_thing_into_editor branch January 26, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants