Skip to content

Switch CI over to CMake/Ninja#139

Merged
majcosta merged 2 commits into
1dot13:masterfrom
majcosta:pr_cmake_ci
Apr 22, 2023
Merged

Switch CI over to CMake/Ninja#139
majcosta merged 2 commits into
1dot13:masterfrom
majcosta:pr_cmake_ci

Conversation

@majcosta
Copy link
Copy Markdown
Contributor

Looks like this thing is working, and builds ~50% faster than msbuild, so we can save on those GitHub Action minutes

CptMoore and others added 2 commits April 22, 2023 01:42
create empty CMakeUserPresets.json file so build happens on first run
comment doesn't apply anymore
no need to specify the compiler when using msbuild@xxx
ask ninja for the verbose command line when building
@majcosta majcosta requested a review from CptMoore April 22, 2023 05:03
Copy link
Copy Markdown
Contributor

@CptMoore CptMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@majcosta majcosta merged commit 74f4979 into 1dot13:master Apr 22, 2023
@majcosta majcosta deleted the pr_cmake_ci branch April 22, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants