[Fix] A bunch of fixes for artillery strike#149
Merged
Merged
Conversation
Contributor
sun-alf
commented
May 22, 2023
sun-alf
commented
- Avoid using hard-coded Signal and HE mortar shell indices. This caused art.strikes malfunctioning in item mods.
- Trim max nubers of waves to duration of signal smoke. Otherwise art.strike turns into unnatural stupidity.
- If enemy AI tried to get art.strike but lacked of resources, player will not a warning anymore.
* Avoid using hard-coded Signal and HE mortar shell indices. This caused art.strikes malfunctioning in item mods. * Trim max nubers of waves to duration of signal smoke. Otherwise art.strike turns into unnatural stupidity. * If enemy AI tried to get art.strike but lacked of resources, player will not a warning anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.