Skip to content

Fix MapEditor target for VS2017#21

Merged
rftrdev merged 1 commit into
1dot13:masterfrom
greymeister:vs2017-fix
Nov 10, 2022
Merged

Fix MapEditor target for VS2017#21
rftrdev merged 1 commit into
1dot13:masterfrom
greymeister:vs2017-fix

Conversation

@greymeister
Copy link
Copy Markdown
Contributor

Based on what I read here and this answer I added legacy_stdio_definitions.lib to the Additional Dependencies linker step.

Hoping that someone could test this branch in their environment to be sure that this still builds properly in other environments.

The error I was receiving before no longer occurrs during build:

"J:\1dot13.git\ja2_VS2017.sln" (default target) (1) ->
"J:\1dot13.git\ja2_VS2017.vcxproj.metaproj" (default target) (8) ->
"J:\1dot13.git\ja2_VS2017.vcxproj" (default target) (20) ->
(Link target) ->
  RakNetLibStatic.lib(LogCommandParser.obj) : error LNK2019: unresolved external symbol __vsnprintf referenced in function "public: void _
cdecl LogCommandParser::WriteLog(char const *,char const *,...)" (?WriteLog@LogCommandParser@@QAAXPBD0ZZ) [J:\1dot13.git\ja2_VS2017.vcxpro
]
  RakNetLibStatic.lib(RakNetTransport.obj) : error LNK2001: unresolved external symbol __vsnprintf [J:\1dot13.git\ja2_VS2017.vcxproj]
  RakNetLibStatic.lib(TelnetTransport.obj) : error LNK2001: unresolved external symbol __vsnprintf [J:\1dot13.git\ja2_VS2017.vcxproj]
  RakNetLibStatic.lib(RakString.obj) : error LNK2001: unresolved external symbol __vsnprintf [J:\1dot13.git\ja2_VS2017.vcxproj]
  J:\1dot13.git\\lib\VS2010\JA2_EN\MapEditor\\MapEditor_EN_Release.exe : fatal error LNK1120: 1 unresolved externals [J:\1dot13.git\ja2_VS
017.vcxproj]

    859 Warning(s)
    5 Error(s)

@Asdow
Copy link
Copy Markdown
Contributor

Asdow commented Nov 9, 2022

That same addition has been done previously to VS2019 project when it was introduced. Should be okay to merge this

@rftrdev
Copy link
Copy Markdown
Contributor

rftrdev commented Nov 10, 2022

Agreed, especially since that addition is already present in the VS2017 solution in the Release config.

@rftrdev rftrdev merged commit 85f2481 into 1dot13:master Nov 10, 2022
@greymeister greymeister deleted the vs2017-fix branch November 11, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants