Fix MapEditor target for VS2017#21
Merged
Merged
Conversation
…ditional libraries as per https://stackoverflow.com/a/34230122
Contributor
|
That same addition has been done previously to VS2019 project when it was introduced. Should be okay to merge this |
Contributor
|
Agreed, especially since that addition is already present in the VS2017 solution in the Release config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on what I read here and this answer I added
legacy_stdio_definitions.libto the Additional Dependencies linker step.Hoping that someone could test this branch in their environment to be sure that this still builds properly in other environments.
The error I was receiving before no longer occurrs during build: