Skip to content

Downgrade startup ini errors to warnings#229

Merged
rftrdev merged 1 commit into
1dot13:masterfrom
Xiaoxun92:master
Sep 23, 2023
Merged

Downgrade startup ini errors to warnings#229
rftrdev merged 1 commit into
1dot13:masterfrom
Xiaoxun92:master

Conversation

@Xiaoxun92
Copy link
Copy Markdown
Contributor

@Xiaoxun92 Xiaoxun92 commented Sep 21, 2023

@rftrdev
Copy link
Copy Markdown
Contributor

rftrdev commented Sep 22, 2023

This looks fine, but can you post a screenshot of how this looks?

Edit: and how long are the warnings visible?

@Xiaoxun92
Copy link
Copy Markdown
Contributor Author

Sure! Here is the screenshot:
image

The text took ~14s to disappear on my old Alienware laptop loading from an HDD. Might be faster on a better device. But either way, the for loop I deleted didn't help extend the visible time because the text only appeared after the loop finished running.

@rftrdev rftrdev merged commit 4ebae98 into 1dot13:master Sep 23, 2023
@rftrdev
Copy link
Copy Markdown
Contributor

rftrdev commented Sep 23, 2023

If you wanna do a follow up investigation as to why the same error is printed twice that'd be swell (but no pressure 🙂)

@Xiaoxun92
Copy link
Copy Markdown
Contributor Author

I noticed that as well and investigated it a bit :)

The same error message was generated in 2 places on startup:

  1. InitializeGame -> LoadGameExternalOptions
  2. InitializeGame -> LoadFeatureFlags -> UpdateFeatureFlags -> LoadGameExternalOptions

Any suggestions on how to improve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downgrade startup errors to warnings

2 participants