Conversation
implemented in container.cpp
Contributor
Author
|
As of now, the only reference left is to HCONTAINER in FileMan.cpp -> GetFilesInDirectory() but that function is not used in the code. It's probably related to alternate code paths if VFS is not used. Might make sense to only remove it, and ultimately container.h & .cpp after we nuke all the #ifdefs related to VFS. |
majcosta
reviewed
Oct 8, 2023
majcosta
reviewed
Oct 8, 2023
Replaces the use of old custom list implementation in container.cpp
instead of old custom code from container.cpp * Removed initialize and shutdown event manager calls from Init.cpp as they were only used to create and destroy the old HLIST globals * Moved code from Event Manager.cpp to Event Pump.cpp as the event queue system is only used in said file. * Removed now useless event manager.cpp and .h files
* Dialogue control.cpp * vsurface.cpp * Event pump.cpp
majcosta
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this comment at the top of the file
// 1998 KM Detached all references to this file from JA2 as it caused a lot of hard to debug crashes
//The VOBJECT/VSURFACE lists are now self-maintained and no longer use the
//this crap. DON'T USE THIS -- NO MATTER WHAT!!!
I'm removing all references to these old custom containers from the code. Contrary to the comment, they actually were still in use for example for VSURFACE.