ASD/ARC: Fix Error by One in gasCan Vector#472
Merged
Conversation
BeatAroundTheBuscher
force-pushed
the
fix_asd_off_by_one
branch
from
cb9c1fb to
ef3a7e4
Compare
BeatAroundTheBuscher
changed the title
rftrdev
requested changes
Aug 1, 2025
Contributor
rftrdev
left a comment
rftrdev
left a comment
There was a problem hiding this comment.
Thanks! Can you wrap the whole thing in a check to make sure we actually have at least one gas can ID?
BeatAroundTheBuscher
force-pushed
the
fix_asd_off_by_one
branch
from
de3c04f to
4f9efbc
Compare
rftrdev
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ARC mission
DISRUPT_ASD_STEAL_FUELcrashes the game at 00:00. InsideApplyAdditionalASDEffectsthe vectorItemIdCache::gasCansis indexed by .size() which returns the size of 1. But since indexes start at 0 the game tries to access memory that isn't reserved for this vector.