QoL: Right Click to fast forward one hour#488
Merged
majcosta merged 1 commit intoAug 24, 2025
Conversation
majcosta
reviewed
Aug 24, 2025
| BOOLEAN fTimeCompressHasOccured = FALSE; | ||
|
|
||
| // run time compression till next hour? | ||
| BOOLEAN fStopTimeCompressionNextHour = FALSE; |
Contributor
There was a problem hiding this comment.
Since this is new code, you can just use bool. Also no need for the "f" prefix.
| } | ||
|
|
||
| btn->uiFlags|=(BUTTON_CLICKED_ON); | ||
| btn->uiFlags|=(BUTTON_CLICKED_ON); |
Contributor
There was a problem hiding this comment.
Avoid mixing formatting changes with code changes. Separate functional and non-functional changes.
Comment on lines
+711
to
+712
| } | ||
| else if(reason & MSYS_CALLBACK_REASON_RBUTTON_DWN ) | ||
| else if(reason & MSYS_CALLBACK_REASON_RBUTTON_DWN ) |
|
|
||
| btn->uiFlags|=(BUTTON_CLICKED_ON); | ||
| } | ||
| // Buscher |
Contributor
There was a problem hiding this comment.
No need for this, git has Snitch and it knows it was you.
| fMapScreenBottomDirty = TRUE; | ||
|
|
||
| fStopTimeCompressionNextHour = TRUE; | ||
| //RequestIncreaseInTimeCompression(); |
BeatAroundTheBuscher
force-pushed
the
fast_forward_one_hour
branch
from
4c2786b to
d348d13
Compare
BeatAroundTheBuscher
force-pushed
the
fast_forward_one_hour
branch
from
d348d13 to
e22e104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quality of life feature to auto stop time compression once
HandleHourlyUpdateis called. By right clicking on the relevant button forMAP_TIME_COMPRESS_MORE(strategic screen bottom right), time compression is set to 60 minutes and is automatically reset once a full hour has passed. This doesn't affect the normal behaviour with left click.By setting the new bool
stopTimeCompressionNextHourinSetGameTimeCompressionLevel, it is also set to false when an event happens inside the hour (for example moving into a new sector)Some minor reformatting was done inBtnTimeCompressMoreMapScreenCallbackto indent lines with the expected amounts of whitespace.