More unused stuff removal#49
Merged
Merged
Conversation
Asdow
reviewed
Dec 25, 2022
majcosta
force-pushed
the
pr_remove_unused_gigaheaders
branch
from
4b30bea to
43ae7da
Compare
delete: - giant 'metaheaders' (JA2 All.h, Laptop All.h, etc), preferring to add #includes directly where needed - unused ExceptionHandling and DbMan translation units - unused WizShare.h, Bitmap.h, trle.h, video_private.h headers
majcosta
force-pushed
the
pr_remove_unused_gigaheaders
branch
from
43ae7da to
43b5b39
Compare
find . -iname '*.h' -o -iname '*.cpp' -exec unifdef.exe -m -UPRECOMPILED_HEADERS -UJA2_PRECOMPILED_HEADERS -UWIZ8_PRECOMPILED_HEADERS -UPRECOMPILEDHEADERS {} ';'
then manually fixed a couple files the tool errored out on
as title
majcosta
added a commit
to majcosta/source
that referenced
this pull request
Jan 10, 2023
Asdow
pushed a commit
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete: