Skip to content

#11 - rely on scaffolding in 1xINTERNET/create-dxp-playwright #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
normanlolx merged 1 commit into from
Feb 24, 2026
Merged

#11 - rely on scaffolding in 1xINTERNET/create-dxp-playwright #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions commands/host/1x-playwright-host-install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,25 +27,12 @@ echo -e "Creating test-directory $DDEV_APPROOT/test/playwright"
mkdir -p $DDEV_APPROOT/test/playwright

# Adjust for 1X-internet private repository
# @todo probably this should be removed.
echo -e "${GREEN}Adjust .npmrc${NC}"
pushd $DDEV_APPROOT/test/playwright && echo '@dxp:registry=https://git.1xinternet.de/api/v4/packages/npm/' >> .npmrc ; popd

# To install with npx.
pushd $DDEV_APPROOT/test/playwright && npx --yes @1xinternet/create-dxp-playwright --lang=Javascript --quiet

if [! ddev exec "command -v jq" &> /dev/null ]; then
playwright_error = "jq command not found in ddev web container - you'll need to adjust the test/playwright/playwright.config.ts manually!"
echo -e "${RED}jq command not found - you'll need to adjust the test/playwright/playwright.config.ts manually!"
else
ddev_hostname=`ddev status -j | ddev exec jq -r .raw.hostnames[0]`
# @todo: better templating of this, e.g. we normally *don't* test in parallel in 4 browsers ...
# Make this work on MacOS and Linux >.<
if [[ $OSTYPE == darwin* ]]; then
pushd $DDEV_APPROOT/test/playwright && sed -i '' "s@http://127.0.0.1:3000@https://${ddev_hostname}@g" playwright.config.ts && popd
else
pushd $DDEV_APPROOT/test/playwright && sed -i "s@http://127.0.0.1:3000@https://${ddev_hostname}@g" playwright.config.ts && popd
fi
fi
pushd $DDEV_APPROOT/test/playwright && npx --yes @1xinternet/create-dxp-playwight --lang=Javascript --quiet

echo -e "\n${CYAN}Please check above for any comments/errors: you might have to run 'npx to test/playwright\n\n"
echo -e "${GREEN}To run tests change to 'test/playwright/' directory ('cd $DDEV_APPROOT/test/playwright/') and run 'npx playwright test example'\n"
21 changes: 2 additions & 19 deletions commands/host/1x-playwright-install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,13 @@ BROWN='\033[0;33m'
NC='\033[0m' # No Color

echo -e "${GREEN}Installing playwright (within DDEV):${NC}"
ddev get lullabot/ddev-playwright
ddev add-on get lullabot/ddev-playwright
ddev restart

ddev exec -d /var/www/html/ mkdir -p test/playwright
# Adjust for 1X-internet private repository
echo -e "${GREEN}Adjust .npmrc${NC}"
pushd $DDEV_APPROOT/test/playwright && echo '@dxp:registry=https://git.1xinternet.de/api/v4/packages/npm/' >> .npmrc ; popd
ddev exec -d /var/www/html/ "mkdir -p test/playwright"

# To install with npx.
pushd $DDEV_APPROOT/test/playwright && npx --yes @1xinternet/create-dxp-playwright --lang=Javascript --quiet

if [! ddev exec "command -v jq" &> /dev/null ]; then
echo -e "${RED}jq command not found in ddev web container - you'll need to adjust the test/playwright/playwright.config.ts manually!"
else
ddev_hostname=`ddev status -j | ddev exec jq -r .raw.hostnames[0]`
# @todo: better templating of this, e.g. we normally *don't* test in parallel in 4 browsers ...
# Make this work on MacOS and Linux >.<
if [[ $OSTYPE == darwin* ]]; then
pushd $DDEV_APPROOT/test/playwright && sed -i '' "s@http://127.0.0.1:3000@https://${ddev_hostname}@g" playwright.config.ts && popd
else
pushd $DDEV_APPROOT/test/playwright && sed -i "s@http://127.0.0.1:3000@https://${ddev_hostname}@g" playwright.config.ts && popd
fi

fi

# Install playwright *inside* the ddev container (see lullabot/ddev-playwright)
ddev install-playwright