#40 review harden token setup by sreina-1x · Pull Request #41 · 1xINTERNET/ddev-onex

Fix shell quoting in 1x-playwright test command so user args and --ui flags are passed as separate arguments instead of one concatenated string

sreina-1x

committed

Fix test assertion for auth token path to match the broader scope (//git.1xinternet.de/:_authToken=) that the script has been writing since commit 6f42954

sreina-1x

committed

Make 1x-token-setup executable (100755) to match all other ddev host commands

sreina-1x

committed

Replace redundant ddev stop + ddev start with single ddev restart at end of 1x-token-setup

sreina-1x

committed

Add preflight check in 1x-playwright to verify npm token is configured and guide developers to run 1x-token-setup if missing

sreina-1x

committed

Replace grep-guard with sed-remove-then-append for npm scoped registries to clean up duplicates and stale URLs on re-runs

sreina-1x

committed

Fix non-interactive mode hanging on read when no token is found, and fix .composer symlink failing when homeadditions/.composer is a real directory

sreina-1x

committed

Remove unnecessary npmrc persist-back-to-host prompt since the script already writes directly to ~/.npmrc before ddev starts

sreina-1x

committed

Add missing 'undefined' check for npm config get in 1x-playwright-install so it correctly detects when @dxp registry is not configured

sreina-1x

committed

Mask personal access token in stdout output to prevent accidental exposure in screen sharing or logs

sreina-1x

committed

Use -e instead of -f test for .gitconfig symlink check so broken symlinks are detected and not attempted to be recreated

sreina-1x

committed

Add missing @1xinternet npm scope (group 4) to match the intranet setup guide and add test assertion for it

sreina-1x

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#40 review harden token setup#41

#40 review harden token setup#41
frega merged 12 commits intomainfrom
#40-review-harden-token-setup

Commits on Mar 6, 2026

Fix shell quoting in 1x-playwright test command so user args and --ui flags are passed as separate arguments instead of one concatenated string

Fix test assertion for auth token path to match the broader scope (//git.1xinternet.de/:_authToken=) that the script has been writing since commit 6f42954

Make 1x-token-setup executable (100755) to match all other ddev host commands

Replace redundant ddev stop + ddev start with single ddev restart at end of 1x-token-setup

Add preflight check in 1x-playwright to verify npm token is configured and guide developers to run 1x-token-setup if missing

Replace grep-guard with sed-remove-then-append for npm scoped registries to clean up duplicates and stale URLs on re-runs

Fix non-interactive mode hanging on read when no token is found, and fix .composer symlink failing when homeadditions/.composer is a real directory

Remove unnecessary npmrc persist-back-to-host prompt since the script already writes directly to ~/.npmrc before ddev starts

Add missing 'undefined' check for npm config get in 1x-playwright-install so it correctly detects when @dxp registry is not configured

Mask personal access token in stdout output to prevent accidental exposure in screen sharing or logs

Use -e instead of -f test for .gitconfig symlink check so broken symlinks are detected and not attempted to be recreated

Add missing @1xinternet npm scope (group 4) to match the intranet setup guide and add test assertion for it