Merged
Conversation
Member
|
Looks good! One thing to consider adding in the future (at least for our local version) would be including an example rpc file in test_rpc files and also including Pleiades Neo in these tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found that Pleiades Neo has a different format from other Pleiades satellites, resulting in an error when running
s2p.I am not 100% sure if I got the direct model (
ImagetoGround_Values) and the inverse model (GroundtoImage_Values) in the correct order. But it sounds correct and the parameter's names seemed to match the other format best like this.There are two parameters that are not used in this parsing of the XML:
GroundtoImage_Validity_DomainandImagetoGround_Validity_Domain. Not sure if they should be parsed somehow as well.