Open
Conversation
aaronjensen
changed the title
It will be started by us. We also should not include logger in our applications because we don't want to start it before we start.
aaronjensen
force-pushed
the
do-not-start-syslog
branch
from
9fecd50 to
9049023
Compare
aaronjensen
changed the title
Contributor
Author
|
@bitwalker does this seem right to you? We can include exsyslog as a normal library application (I'm not sure if it's a problem that ExSyslog itself is a I wasn't able to get it working conssitently when I put syslog in applications and relied on it starting before logger would try to init ExSyslog. |
Contributor
Author
|
I tested this locally and deployed via exrm, both worked well. |
|
Yep this looks exactly right :) |
Contributor
Author
|
Awesome, thanks @bitwalker. @mr-bt look good? |
|
@mr-bt any reason we can't get this merged? |
ahamez
added a commit
to EasyMile/exsyslog
that referenced
this pull request
Aug 21, 2016
See 22cans#6 for details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies setup and seems to work. I think it's more correct.
This supersedes #5