Gsdm 41 #22
Gsdm 41 #22
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates submodule configuration and adds a new staging CI workflow. The changes remove an unused submodule, update the mobile-offline-downloader-android submodule URL to use HTTPS, and introduce a GitHub Actions workflow for staging builds with Firebase distribution support.
- Removes the android-vault submodule and updates mobile-offline-downloader-android URL to HTTPS
- Adds comprehensive staging CI workflow with unit testing, APK building, and Firebase distribution
- Supports both pull request triggers and manual workflow dispatch with configurable options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .gitmodules | Removes android-vault submodule and updates mobile-offline-downloader-android URL to HTTPS |
| .github/workflows/Staging.yml | Adds new staging CI workflow with build, test, and Firebase distribution capabilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| grep -r "<testsuite" app/build/test-results | \ | ||
| sed -n 's/.*tests=\"\([0-9]*\)\" failures=\"\([0-9]*\)\" errors=\"\([0-9]*\)\".*/- Total: \1, Failures: \2, Errors: \3/p' >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
The path 'app/build/test-results' is incorrect. Based on the workflow, tests are run in the 'apps' directory for the ':student' module, so the path should be 'apps/student/build/test-results' to correctly locate the test results.
| app/build/test-results | ||
| app/build/reports/tests |
There was a problem hiding this comment.
The artifact upload paths reference 'app/build/' but should reference 'apps/student/build/' to match the actual build output location. The test results and reports are generated in the student module within the apps directory.
| - name: Cleanup sensitive files and directories | ||
| run: | | ||
| echo "Cleaning up sensitive files..." | ||
| rm -rf app |
There was a problem hiding this comment.
Attempting to remove 'app' directory that doesn't exist. The workflow uses 'apps' directory (plural), and the cleanup should either remove 'apps' or specific sensitive files within it. This command will fail silently or have no effect.
| rm -rf app | |
| rm -rf apps |
| run: | | ||
| echo "Cleaning up sensitive files..." | ||
| rm -rf app | ||
| rm -rf buildSrc |
There was a problem hiding this comment.
The buildSrc directory is located at 'apps/buildSrc' based on line 77, not at the repository root. This cleanup command targets the wrong path and won't remove the sensitive Secure.kt file created earlier.
| rm -rf buildSrc | |
| rm -rf apps/buildSrc |
1 participant
No description provided.