Tireons bugfix - crashing when launching pod with cargo in Space Exploration#26
Open
pmendl wants to merge 3 commits into321freddy:masterfrom
Open
Tireons bugfix - crashing when launching pod with cargo in Space Exploration#26pmendl wants to merge 3 commits into321freddy:masterfrom
pmendl wants to merge 3 commits into321freddy:masterfrom
Conversation
This was referenced Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did it myself... Not yet tested at all above that launch now did not crash the game.
Obviously probem was in timing of sequence when pod gets destroyed in one surface and created (probably with different ID) in another, while event got the ID of the destroyed one.
Fix is quite simple, so I do not expect massive troubles, however some testing would be fine (I am playing Factorio actively, so will see myself too).