Skip to content

Xch 1388 gdpr compliance#21

Merged
curlyblueeagle merged 3 commits intomasterfrom
XCH-1388_gdpr_compliance
Jun 26, 2019
Merged

Xch 1388 gdpr compliance#21
curlyblueeagle merged 3 commits intomasterfrom
XCH-1388_gdpr_compliance

Conversation

@curlyblueeagle
Copy link
Collaborator

@curlyblueeagle curlyblueeagle commented Jun 25, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Updated sync logic for gdpr scenarios

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

clazy
clazy reviewed Jun 25, 2019
View reviewed changes
modules/33acrossBidAdapter.js Outdated
sync.url = `${sync.url}&gdpr=${gdpr}`;
}

sync.url = `${sync.url}&gdpr_consent=${consentString}`;
Copy link

@clazy clazy Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to use the util function parseQueryStringParameters() provided by prebidjs (https://github.com/33Across/Prebid.js/blob/master/src/utils.js#L132), it does the encoding on the value, but do we need the encoding on the consentString??

Copy link
Collaborator Author

@curlyblueeagle curlyblueeagle Jun 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using the util since it does not work well with the expected URL structure. However I am directly encoding the consent string using encodeURIComponent

clazy
clazy reviewed Jun 25, 2019
View reviewed changes
modules/33acrossBidAdapter.js Outdated
};

if (typeof gdprApplies === 'boolean') {
const gdpr = gdprMap[gdprApplies.toString()];
Copy link

@clazy clazy Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do Number(gdprApplies), as long as gdprApplies is boolean, this will either convert it to 0 or 1, so you do not need the gdprMap

@curlyblueeagle curlyblueeagle requested review from clazy and removed request for glebglushtsov June 26, 2019 02:38
@curlyblueeagle curlyblueeagle merged commit 5b1eb46 into master Jun 26, 2019
@curlyblueeagle curlyblueeagle deleted the XCH-1388_gdpr_compliance branch June 26, 2019 02:40
curlyblueeagle pushed a commit that referenced this pull request Jun 4, 2020
@SublimeLeo @ghourlier @fgcloutier
SublimeBidAdapter: Update to version 0.5.1 (prebid#4977)
6311c46 
* add prebid version of adapter

* Feature/update sublime adapter (#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (#22)

* add prebid version of adapter
* Feature/update sublime adapter (#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
curlyblueeagle pushed a commit that referenced this pull request Mar 22, 2021
@JeremiePat @ghourlier
@SublimeLeo @fgcloutier
Sublime Bid Adapter: v0.7.1 & add extra information in tracking pixels (
81a9e2b 
prebid#6442)

* add prebid version of adapter

* Feature/update sublime adapter (#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (#22)

* add prebid version of adapter
* Feature/update sublime adapter (#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

* sublimeAdapter: Improve pixels data

* sublimeAdapter: Update tests

* sublimeAdapter: Rename data

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com>
carlosfelix pushed a commit that referenced this pull request Aug 30, 2023
@juliangan07 @jsadwith
Kargo Bid Adapter: Forward schain in the request (prebid#10202)
361cf62 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

---------

Co-authored-by: Jeremy Sadwith <jeremy@kargo.com>
macinjosh32 pushed a commit that referenced this pull request Oct 17, 2023
@njflynn @jsadwith @juliangan07
Kargo Bid Adapter: adding site to Kargo adapter (prebid#10589)
1a40e59 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

---------

Co-authored-by: Jeremy Sadwith <jeremy@kargo.com>
Co-authored-by: Julian Gan <juliangan07@gmail.com>
macinjosh32 pushed a commit that referenced this pull request Oct 17, 2023
@jsadwith @juliangan07 @njflynn
Kargo Bid Adapter: Updates to GPID retrieval (prebid#10618)
665f356 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

* Kargo Bid Adapter: Updates to gpid retrieval

---------

Co-authored-by: Julian Gan <juliangan07@gmail.com>
Co-authored-by: Neil Flynn <nflynn@kargo.com>
macinjosh32 pushed a commit that referenced this pull request Oct 31, 2023
@jsadwith @juliangan07 @njflynn
Kargo Bid Adapter: Support for sending ortb2.user.data (prebid#10659)
a94f7f0 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

* Kargo Bid Adapter: Updates to gpid retrieval

* Support for sending ortb2.user.data

---------

Co-authored-by: Julian Gan <juliangan07@gmail.com>
Co-authored-by: Neil Flynn <nflynn@kargo.com>
carlosfelix pushed a commit that referenced this pull request Mar 15, 2024
@sj1815 @jsadwith
@juliangan07 @njflynn @nickllerandi
Kargo Bid Adapter: floors and CreativeID update (prebid#11153)
77254c2 
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

* Adding site to Kargo adapter.

* KRKPD-619 Updating Site object.

* KRKPD-619 Adding null check for  Site object.

* Update modules/kargoBidAdapter.js

Co-authored-by: Julian Gan  <juliangan07@gmail.com>

* Reducing the size of Site object.

* remove white space that is causing linting error

* Kargo Bid Adapter: Updates to gpid retrieval

* Support for sending ortb2.user.data

* update bid Response to use actual creativeID

* update spec

* fix nomencalature based on Kargo's service

* Prebid.js - Update bid Response to use actual creativeID (#25)

* update bid Response to use actual creativeID

* update spec

* fix nomencalature based on Kargo's service

* utilize floors mod

* fixes tests

* mediatype specific floors

* simpler implementation leveraging Prebid's smart rule selection

* revert nomenclature change

* fix

* removes comment

---------

Co-authored-by: Jeremy Sadwith <jeremy@kargo.com>
Co-authored-by: Julian Gan <juliangan07@gmail.com>
Co-authored-by: Neil Flynn <nflynn@kargo.com>
Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Co-authored-by: Nick Llerandi <nick.llerandi@kargo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clazy clazy Awaiting requested review from clazy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@curlyblueeagle @clazy

Comments