-
Notifications
You must be signed in to change notification settings - Fork 0
Added composedb docker image build to ceramic plan #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrz2001
reviewed
Jun 6, 2023
smrz2001
reviewed
Jun 6, 2023
smrz2001
reviewed
Jun 6, 2023
smrz2001
reviewed
Jun 12, 2023
smrz2001
approved these changes
Jun 13, 2023
Contributor
smrz2001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
smrz2001
reviewed
Jun 13, 2023
Added verify for composedb image Fixed version typo Added build steps for composedb Fixed composeDB image repo name for docker hub normalize ceramic step names Updated _repo for cermic
fed8e20 to
8b53f34
Compare
smrz2001
reviewed
Jun 13, 2023
smrz2001
reviewed
Jun 13, 2023
smrz2001
approved these changes
Jun 13, 2023
Contributor
smrz2001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just copied the existing actions to do the build and push.
I'm not 💯 on the syntax or method to call the builds though.
We can add 2 steps to the
verifyaction and just check the composedb version output?