Assorted WIP fixes and feedback (split off from #287) #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, the closing tag is not located in any of the included files. Heck, the bug makes it through all the way to the client – you can see it in the HTML hosted at <https://3mdeb.com/bug-bounty/>. (Compare that with <https://3mdeb.com/careers/>, which has the "Contact Us" `<section>` as the last direct child of `<main>`. And btw, is there really no tooling to catch things like that?
Punctuation after email addresses seems to always get a space character
added before it – regardless if one was present in the markdown source.
Why?
Making link text **bold** does result in `<strong>` within the HTML but
does not make it look any different. Maybe the other instances of that
should be removed as well?
There are other unmarked links and emails in the Markdown sources:
`grep -r --include="*."{md,toml} -iE '($|[^(<])(http|mailto)'`
What about other instances of `[something](something)` -> `<something>`?
The `content/careers.pl.md` file (hosted at <https://3mdeb.com/praca/>)
doesn't seem to be referenced anywhere. I had to search for its text
with Google to see how that's rendered.
See the open positions listing at <https://3mdeb.com/praca/> This is how the EN version of the document seems to deal with the problem. However, the issue does not occur in the "Do oddziału w Osiu poszukujemy:" section for some reason. Speaking of non-breaking spaces, the entire repo is filled with them! But not as HTML entities like here, but rather as U+00A0 characters inserted throughout the text. It's probably because many XKB layouts have it mapped under Alt+Space, which is quite easy to hit on accident. (there's a ton of other accidental whitespace too) Also, should all of this really be taken care of manually? Why is the green text all applied by hand, with Markdown? And are the EN and PL versions both kept in sync/up-to-date in any way?
(unless it's suposed to be German or Latin lol) Also I'm not sure how clear it is to people that this refers to a "dzielnica" of Gdańsk.
Also, there are a few more "ASCII hyphen-minus"es later on, while the other parts generally stick to using en dashes (–) pretty consistently.
Also why CRLFs??? Just why...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, I'm creating a PR here instead of only keeping the commits in a tag. It's a draft with "edits by maintainers" allowed because it's nowhere close to being ready. You can consider this CC0 and shape it into whatever you want (I don't need attribution). In case the descriptions aren't clear I am happy to explain them. I might or might not put more time into this, but I also need to get a few uni assignments done so don't wait for me too long.
Also, when I was rebasing my changes, git really wanted to apply two more unrelated commits for some reason. So unless git got confused by something else, these two are most likely absent from develop: