Skip to content

local installation of development tools #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eguzki merged 3 commits into from
Jun 3, 2021
Merged

local installation of development tools #612

eguzki merged 3 commits into from
Jun 3, 2021

Conversation

@eguzki
Copy link
Member

@eguzki eguzki commented Jun 1, 2021 •
edited
Loading

Install development tools at ${PROJECT_BASE_PATH}/bin. Avoid conflict with the same development tools for different releases required in other working projects.

  • Operator-sdk
  • kustomize
  • controller-gen
  • go-bindata

@eguzki eguzki requested a review from miguelsorianod June 1, 2021 11:58
@eguzki eguzki force-pushed the fix-operator-sdk-release branch from d04d194 to ad87c2d Compare June 1, 2021 12:16
@miguelsorianod
Copy link
Contributor

miguelsorianod commented Jun 1, 2021 •
edited
Loading

Note: go-bindata could not be installed locally as go generate command runs command from annotation and the binary must be found in the $PATH. Usually the project local folders are not included in the system $PATH.

To solve this issue we can update the PATH in the beginning of the Makefile to add the new local bin path with preference over the other directories and export the variable so subprocesses use it

miguelsorianod
miguelsorianod reviewed Jun 1, 2021
View reviewed changes
Makefile Outdated

OPERATOR_SDK = $(PROJECT_PATH)/bin/operator-sdk
$(OPERATOR_SDK):
curl -sSL https://github.com/operator-framework/operator-sdk/releases/download/v1.2.0/operator-sdk-v1.2.0-x86_64-linux-gnu -o $(OPERATOR_SDK)
Copy link
Contributor

@miguelsorianod miguelsorianod Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note here: This will be architecture dependent. If other people are trying to use it from other architectures it will fail.

Copy link
Member Author

@eguzki eguzki Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

It would be good if @krishvoor could test on ppc64le arch

@eguzki eguzki force-pushed the fix-operator-sdk-release branch from 407c12a to 5fdcb8d Compare June 1, 2021 22:47
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jun 1, 2021

Code Climate has analyzed commit 5fdcb8d and detected 0 issues on this pull request.

View more on Code Climate.

@eguzki eguzki merged commit 4daa2ec into master Jun 3, 2021
@eguzki eguzki deleted the fix-operator-sdk-release branch June 3, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eguzki @miguelsorianod