Skip to content

Conversation

@eguzki
Copy link
Member

@eguzki eguzki commented Jun 7, 2021

@eguzki eguzki requested a review from miguelsorianod June 7, 2021 11:02
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eguzki eguzki force-pushed the fix-alm-samples branch from 682a45e to 31957a9 Compare June 7, 2021 11:08
@eguzki eguzki marked this pull request as ready for review June 7, 2021 11:08
@eguzki eguzki force-pushed the fix-alm-samples branch from c2119c8 to f85c296 Compare June 7, 2021 11:19
* [3scale installation Backup and Restore using the operator (in *TechPreview*)](operator-backup-and-restore.md)
* [Application Capabilities (in *TechPreview*)](operator-application-capabilities.md)
* [APIManager CRD reference](apimanager-reference.md)
* [APIManager CR samples](cr_samples/apimanager/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include a link to the one from config/samples which is the simple one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good. I left a minor comment

@eguzki eguzki force-pushed the fix-alm-samples branch from f85c296 to 5d4cdd8 Compare June 7, 2021 11:43
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 5d4cdd8 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eguzki eguzki merged commit e6646e0 into master Jun 7, 2021
@eguzki eguzki deleted the fix-alm-samples branch June 7, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants