Skip to content

Make application plans publication state configurable #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miguelsorianod merged 1 commit into from
Aug 3, 2021
Merged

Make application plans publication state configurable #643

miguelsorianod merged 1 commit into from
Aug 3, 2021

Conversation

@miguelsorianod
Copy link
Contributor

@miguelsorianod miguelsorianod commented Jul 23, 2021 •
edited
Loading

Implement Applications Plan publication configurability in a Product.
A published attribute has been implemented to control it, and the Product CR looks like this:

...
applicationPlans:
 production:
   name: "production"
   published: true
...

If not specified, by default it is false.

Pending:

  • Verification

@miguelsorianod miguelsorianod requested a review from eguzki July 23, 2021 09:10
@miguelsorianod miguelsorianod changed the title [WIP] Make application plans publication state configurable Make application plans publication state configurable Jul 28, 2021
@miguelsorianod miguelsorianod force-pushed the make-appplans-publish-configurable branch from f252c6c to 7f0d6d3 Compare July 28, 2021 08:35
@miguelsorianod
Copy link
Contributor Author

miguelsorianod commented Jul 28, 2021

Ready for review @eguzki

eguzki
eguzki requested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things. Looking good.

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Aug 2, 2021
@miguelsorianod miguelsorianod force-pushed the make-appplans-publish-configurable branch from 7f0d6d3 to 7b4fd3b Compare August 2, 2021 15:12
@miguelsorianod miguelsorianod requested a review from eguzki August 2, 2021 15:25
@miguelsorianod miguelsorianod force-pushed the make-appplans-publish-configurable branch from 7b4fd3b to 1e4a582 Compare August 2, 2021 15:33
eguzki
eguzki reviewed Aug 2, 2021
View reviewed changes
@miguelsorianod miguelsorianod force-pushed the make-appplans-publish-configurable branch from 1e4a582 to 618f0b5 Compare August 3, 2021 08:55
@miguelsorianod
Copy link
Contributor Author

miguelsorianod commented Aug 3, 2021

added documentation in product reference doc

@miguelsorianod miguelsorianod force-pushed the make-appplans-publish-configurable branch from 618f0b5 to 8dfcf09 Compare August 3, 2021 10:19
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Aug 3, 2021

Code Climate has analyzed commit 8dfcf09 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Style 2

View more on Code Climate.

@miguelsorianod miguelsorianod merged commit f00f981 into master Aug 3, 2021
@eguzki eguzki deleted the make-appplans-publish-configurable branch August 3, 2021 12:43
This was referenced Aug 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eguzki eguzki eguzki approved these changes

Assignees

@eguzki eguzki

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miguelsorianod @eguzki