t/configuration-loading-lazy.t: convert to APIcast::Blackbox #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
commented
May 27, 2022
7 tasks
samugi
reviewed
May 30, 2022
Member
Author
|
ready for review @samugi |
samugi
reviewed
Jun 1, 2022
t/configuration-loading-lazy.t
Outdated
| using lazy configuration loader | ||
|
|
||
| === TEST 2: load invalid configuration | ||
| should fail with server error |
Contributor
There was a problem hiding this comment.
apparently this is not true, it is just expected to behave the same as empty, I would replace with "should say service not found"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.