t/apicast-async-reporting.t: convert to APIcast::Blackbox #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
commented
May 31, 2022
7 tasks
samugi
commented
May 31, 2022
eguzki
requested changes
May 31, 2022
| ngx.log(ngx.ERR, 'invalid host: ', ngx.var.host) | ||
| ngx.exit(404) | ||
| end | ||
| if ngx.var.host == 'test_backend' then |
Member
There was a problem hiding this comment.
not sure this is correct.
The Blackbox.pm sets backend override env var. This test, if it makes any sense, should "unset" the backend override endpoint and use the one configured from the configuration
backend = {
endpoint = 'http://localhost.example.com:$TEST_NGINX_SERVER_PORT'
},
Contributor
Author
There was a problem hiding this comment.
all set. I'm still using test_backend as a host so we don't actually need to reconfigure dns, but now the configuration comes from the backend/endpoint value
| ngx.log(ngx.ERR, 'invalid host: ', ngx.var.host) | ||
| ngx.exit(404) | ||
| end | ||
| if ngx.var.host == 'test_backend' then |
Member
There was a problem hiding this comment.
not sure this is correct.
The Blackbox.pm sets backend override env var. This test, if it makes any sense, should "unset" the backend override endpoint and use the one configured from the configuration
backend = {
endpoint = 'http://localhost.example.com:$TEST_NGINX_SERVER_PORT'
},
eguzki
requested changes
May 31, 2022
eguzki
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.