Skip to content

t/apicast-caching.t tests conversion to blackbox#1351

Merged
eguzki merged 1 commit intotests-conversion-to-blackboxfrom
caching-test
Jun 6, 2022
Merged

t/apicast-caching.t tests conversion to blackbox#1351
eguzki merged 1 commit intotests-conversion-to-blackboxfrom
caching-test

Conversation

@eguzki
Copy link
Member

@eguzki eguzki commented Jun 3, 2022

No description provided.

@eguzki eguzki requested a review from samugi June 3, 2022 15:30
@eguzki eguzki requested a review from a team as a code owner June 3, 2022 15:30
apicast cache miss key: 2:two-id:two-key:usage%5Bhits%5D=2
apicast cache write key: 2:two-id:two-key:usage%5Bhits%5D=2

=== TEST 3: call to backend is cached
Copy link
Member Author

@eguzki eguzki Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST 1 and TEST 3 were identical

Thus, removing

Copy link
Contributor

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@eguzki eguzki merged commit 7137238 into tests-conversion-to-blackbox Jun 6, 2022
@eguzki eguzki deleted the caching-test branch June 6, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants