Skip to content

Conversation

@eguzki
Copy link
Member

@eguzki eguzki commented Feb 5, 2024

WHAT

Dev environments use docker compose up instead of docker compose run.

I was confused when using docker compose run that when listing the containers running in the project, apicast was not there. I learned it is because we were using docker compose run. Then I learned that run command is meant fro running "one-off" task. More appropriate for running tests. Furthermore, it does not respect some service configuration like command or ports.

@eguzki eguzki changed the title docker compose up instead of docker compose run ocker compose up instead of docker compose run Feb 5, 2024
@eguzki eguzki changed the title ocker compose up instead of docker compose run Docker compose up instead of docker compose run Feb 5, 2024
@eguzki eguzki marked this pull request as ready for review February 5, 2024 09:34
@eguzki eguzki requested a review from a team as a code owner February 5, 2024 09:34
@eguzki eguzki requested a review from tkan145 February 5, 2024 09:34
@eguzki eguzki force-pushed the docker-compose-up-instead-of-run branch from 133d3fd to cef0721 Compare February 5, 2024 09:42
@tkan145
Copy link
Contributor

tkan145 commented Feb 5, 2024

LGTM!

@eguzki eguzki force-pushed the docker-compose-up-instead-of-run branch from cef0721 to 8c0713a Compare February 5, 2024 12:28
@eguzki eguzki merged commit 9a7a545 into master Feb 5, 2024
@eguzki eguzki deleted the docker-compose-up-instead-of-run branch February 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants