THREESCALE-11738 - on_failed policy doesn't work with conditional policy

[tkan145]

What

Fix https://issues.redhat.com/browse/THREESCALE-11738

Verification steps:

• Checkout this branch
• Build new runtime-image

make runtime-image IMAGE_NAME=apicast-test

• Get into dev-environments

cd plain-http-upstream 

• Update apicast-config.json

diff --git a/dev-environments/plain-http-upstream/apicast-config.json b/dev-environments/plain-http-upstream/apicast-config.json
index ff944273..147a0d51 100644
--- a/dev-environments/plain-http-upstream/apicast-config.json
+++ b/dev-environments/plain-http-upstream/apicast-config.json
@@ -13,6 +13,38 @@
         "policy_chain": [
           {
             "name": "apicast.policy.apicast"
+          },
+          {
+            "name": "conditional",
+            "version": "builtin",
+            "configuration": {
+              "condition": {
+                "operations": [
+                  {
+                    "left": "{{ uri }}",
+                    "left_type": "liquid",
+                    "op": "==",
+                    "right": "/foo",
+                    "right_type": "plain"
+                  }
+                ]
+              },
+              "policy_chain": [
+                {
+                  "name": "example",
+                  "version": "1.0",
+                  "configuration": {}
+                },
+                {
+                  "name": "on_failed",
+                  "version": "builtin",
+                  "configuration": {
+                    "error_status_code": 419
+                  }
+                }
+              ]
+            },
+            "enabled": true
           }
         ],
         "proxy_rules": [

• Start APIcast

make gateway IMAGE_NAME=apicast-test

• Send request

curl --resolve get.example.com:8080:127.0.0.1 -v "http://get.example.com:8080/?user_key=123" 

You should see HTTP/1.1 200 OK

• Send another request to trigger on_failed policy

curl --resolve get.example.com:8080:127.0.0.1 -v "http://get.example.com:8080/foo?user_key=123" 

419 will be returned this time

[eguzki]

LGTM

Verification steps worked