[wip] policy manifest and it's JSON schema #564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
commented
Jan 25, 2018
| ], | ||
| "version": "1.1", | ||
| "configuration": { | ||
| "$ref": "schema.json#" |
Contributor
Author
There was a problem hiding this comment.
@davidor I'd like to hear what is your though on this.
This would allow us to have schema and manifest in different JSON files, but we would need to use some tool (like json-refs) to merge the doc. It is not a big deal, just pass it through, I verified it works and creates correct output.
Or we can have the schema embedded in the manifest and have just one, bigger JSON.
davidor
reviewed
Jan 25, 2018
| ] | ||
| }, | ||
| "version": { | ||
| "$ref": "#/definitions/version" |
Contributor
There was a problem hiding this comment.
Why did you decide to extract this into its own definition and not do the same with description or name ?
Contributor
Author
There was a problem hiding this comment.
I wanted to try it out and I was expecting this might appear on multiple places, so defining a primitive for other validations.
Contributor
Author
|
Closing in favour of #565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.