Move mapping rule checking to MappingRule and add missing tests #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Feb 5, 2018
gateway/src/apicast/mapping_rule.lua
Outdated
| -- @tparam string path Path of an HTTP request. | ||
| -- @tparam table args Table with the args and values of an HTTP request. | ||
| -- @treturn boolean Whether the mapping rule matches the given request. | ||
| function _M:matches(method, path, args) |
Contributor
There was a problem hiding this comment.
If we introduce SOAP rules that are full URL the path will no longer be just path, but a full URI. But a pathj is an URI. So maybe lets call it uri ?
Notice that this commit does not change functionality. It just moves a method. While at it, remove and old FIXME in Service that references params that no longer exist.
davidor
force-pushed
the
move-mapping-rule-check
branch
from
4c2c0b9 to
8e2d980
Compare
mikz
approved these changes
Feb 5, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor.
This PR moves the method that checks a mapping rule againts a request from the
Servicemodule to theMappingRulemodule. I think it clearly belongs there.This PR also adds some unit tests for the matching of mapping rules.