Skip to content

Make sure all the policy configs used in specs are valid #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidor merged 2 commits into from
Mar 5, 2018
Merged

Make sure all the policy configs used in specs are valid #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1a5f78
spec/policy/cors: change 'allow_headers' to be an array like the conf…
davidor Mar 2, 2018
8e2c8a4
spec/policy/url_rewriting: change 'break' to be a bool like the confi…
davidor Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/policy/cors/cors_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('CORS policy', function()

it('sets those headers', function()
local policy_config = {
allow_headers = 'Content-Type',
allow_headers = { 'Content-Type' },
allow_methods = { 'GET', 'POST' },
allow_origin = '*',
allow_credentials = true
Expand Down
2 changes: 1 addition & 1 deletion spec/policy/url_rewriting/url_rewriting_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('URL rewriting policy', function()
it('when there is a break, stops at the first match', function()
local config_with_break = {
commands = {
{ op = 'gsub', regex = 'to_be_replaced', replace = 'abc', ['break'] = '1' },
{ op = 'gsub', regex = 'to_be_replaced', replace = 'abc', ['break'] = true },
{ op = 'gsub', regex = 'abc', replace = 'def' } -- Not applied
}
}
Expand Down