Add L1 fee processing to OP Stack (Optimism, Base, opBNB, et al.)#91
Merged
Add L1 fee processing to OP Stack (Optimism, Base, opBNB, et al.)#91
Conversation
jzethar
force-pushed
the
opstack-corrections
branch
from
fc6b339 to
44e02f5
Compare
Har01d
changed the title
alexqrid
reviewed
Sep 17, 2024
| case ExtraBF = 'ExtraBF'; // Same as `ExtraF`, but there can be two events: `f` is the fee paid to the miner, and | ||
| // `b` is the part which is being burnt (see `ethereum-main`) | ||
| // `b` is the part which is being burnt (see `tron-main`) | ||
| case ExtraBFCaret = 'ExtraBF^'; // Same as `ExtraBF`, but all events with extras starting with `f` should also be |
Collaborator
There was a problem hiding this comment.
More fee types for the fee types God?
What's the necessity of these fee types?
Har01d
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR there are some fixes for OPStack modules: